Comments on: New code-view feature

By: Simon

Simon — Wed, 18 Mar 2009 10:45:27 +0000

Awesome idea! And thanks for sharing the code!

By: Juno

Juno — Tue, 17 Mar 2009 02:36:29 +0000

Awesome works James. I suggest add another parameter “url”

codeview.php?url=http://jquery.offput.ca/js/jquery.bgColor.js

what u think?

By: Rick

Rick — Sun, 15 Mar 2009 10:19:06 +0000

No problem… it’d only help people like myself who instinctively put a trailing slash on anything that looks like a directory.

By: James

James — Sun, 15 Mar 2009 08:56:55 +0000

@Rick, thanks for the tip, just changed it.

By: Rick

Rick — Sun, 15 Mar 2009 03:42:57 +0000

Looks great but you might want to change the regexp in the .htaccess file to allow trailing slashes… eg “^(.+\.js)/view/?$”

By: fillform

fillform — Sat, 14 Mar 2009 23:46:46 +0000

@James Cleaning probably isn’t required, I just do it with every variable I receive. I get so paranoid.

By: Meshach

Meshach — Sat, 14 Mar 2009 20:35:10 +0000

That is awesome James.

Thanks very much!

By: James

James — Sat, 14 Mar 2009 19:28:18 +0000

@James, yep, GesHi is awesome! I did consider using something like SyntaxHighlighter or Prettify but I really wanted something server-side plus I'd heard a lot of good things about GeSHi... @Vasili, In what way does it need cleaning? The contents of the parameter is not echoed or added to a database so I don't see any security issues.

By: Vasili

Vasili — Sat, 14 Mar 2009 18:35:16 +0000

I would clean $_GET['loc'].

By: James

James — Sat, 14 Mar 2009 18:28:51 +0000

Nicely done. GeSHi is a wonder piece of software. I’ve used it before in a similar vein.